Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

React App. Not mobile compatible yet. Some queries on paddings.

@imparassharma

Desktop design screenshot for the Newsletter sign-up form with success message coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


I use rems pretty much and recently I read somewhere that rems should not be used for paddings and margins. Can anyone look into my code and can tell me the drawbacks of using rems in the given solution and what alternative I can use so to make it more responsive. Any other feedback is also welcome.

Community feedback

@BeinRain06

Posted

Your are welcome, @imparassharma You can link css file in your main.js file of react not do an inline-css. Here above is what I'm suggesting :

create a file called style.css in the same directory that your main.js file

Add some style in this css file. Now to link it to your main.js file: --> open your main.js* file and Write this line at the top :

import "./style.css"

And see if it works to implement your style written on this later file.

Hope that make sense if some issue appears again could leave me some brief explanation I will try to lead my answer through the best I could. Having this nice journey, I'm just keep saying happy coding to you @imparassharma

Marked as helpful

0

@BeinRain06

Posted

Hello @imparassharma I have seen your mobile app. But what I wondering why, you didn't use style.css file to style the whole main.js file

But my quick way to see to correct each section is in mobile to stack the section Stay updated over the section with big image.

For e.g I think you might do something like that :

      <div class="section-one padding-effect">
        <div class = "content-section-one">
          ... // some syntax section one
        </div>
     </div>
     <div class="section-two padding-effect">
       <div class = "content-section-two">
        ... // some syntax section two
       </div>
      </div>

And in style.css try this along or either with your javacsript code:

.general_wrapper {

   width: 100vw;
         ... 
}

.padding-effect {
   width: calc (100%  - 1em)
   margin: 0 auto;
     ... 
   
  }

To make the padding of 1em each time in mobile. Instead using rem units you might use em units in mobile but not in desktop because it become quite large due to the fact that em unit is calculated according to the direct parent element with that grows bigger in desktop style.

Hope you might have a solution to fix the displaying, and also have a nice day /night@imparassharma

1

@imparassharma

Posted

@BeinRain06 first of all thankyou for taking your time out and coming forward to help me but there is some confusion here. As in my title I have not done mobile compatibility yet. Its desktop compatible only.

And by including style.css in main.js file you mean inline css?

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord