React App, Generate Advices from Advice Slip Api

Community feedback

• 

  mitul•360

  @mitulpatel224Posted about 1 year ago

  Hey, This looks nice. Please find some of my observations. I hope it will be helpful to you!

  1. Apply @media for responsive UI.
  2. Apply the default font size in the body. And overwrite it for advice-id elements.
  3. Class ".advice-id" can be <h1>
  4. Class ".advice-text" can be <p>. Use <span> for right-quote and left-quote sign.

  0

  ---

  

  Muhammad Medhat•190

  @muhammad-medhatPosted about 1 year ago

  @mitulpatel224 Thank you for providing feedback on my project! I is there a better way you can suggest so i can adjust my media queries

  0

  

  mitul•360

  @mitulpatel224Posted about 1 year ago

  @muhammad-medhat

  I will suggest creating this with a mobile first approach. In which you first design all the layouts for the smallest device(mobile) and using @media you can modify the look for bigger devices step by step.

  I wrote all CSS for mobile devices and then used @media (min-width: 768px) for bigger screens.

  Marked as helpful

  0

  

  Muhammad Medhat•190

  @muhammad-medhatPosted about 1 year ago

  @mitulpatel224

  Thank you for your advice about the mobile-first approach
  do you have any other comments on my design? again Thank you for all your comments

  0