@mitulpatel224
Posted
Hey, This looks nice. Please find some of my observations. I hope it will be helpful to you!
- Apply @media for responsive UI.
- Apply the default font size in the body. And overwrite it for advice-id elements.
- Class ".advice-id" can be <h1>
- Class ".advice-text" can be <p>. Use <span> for right-quote and left-quote sign.
@muhammad-medhat
Posted
@mitulpatel224 Thank you for providing feedback on my project! I is there a better way you can suggest so i can adjust my media queries
@mitulpatel224
Posted
@muhammad-medhat
I will suggest creating this with a mobile first approach.
In which you first design all the layouts for the smallest device(mobile) and using @media you can modify the look for bigger devices step by step.
I wrote all CSS for mobile devices and then used @media (min-width: 768px) for bigger screens.
Marked as helpful
@muhammad-medhat
Posted
@mitulpatel224
Thank you for your advice about the mobile-first approach do you have any other comments on my design? again Thank you for all your comments
