React and SASS solution

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Akshat Vishwakarma! 👋

  Congrats on finishing another challenge! Your solution works well! Maybe add some :active pseudo-class for your buttons to create "clicking" effect. Also, it would be nicer if you add transitions to this theme change.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  Akshat Vishwakarma•240

  @vishwa-akshatPosted over 3 years ago

  @tediko thank you. I will try to add some effects and transitions to the theme.

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  overall nice but a few issues

  #1 look at your theme switching slider at 1390px with and 1392 px width when it gets to the smaller side your slider is going from a single row to a double row making it hard for the user to then select theme three

  #2 on the calculator logic side a user can type 5++5 and -- ** // and it then locks up the calculator and will not total but 5+-6 does work correct so you need to just fix it for the double or more of the same operator typed in

  1

  ---

  

  Akshat Vishwakarma•240

  @vishwa-akshatPosted over 3 years ago

  Thank you @palgramming I will fix this issue;

  0