React advice generator app

Community feedback

• 

  Danilo Blas•6,300

  @Sdann26Posted over 2 years ago

  Hi Mounir!

  Congratulations for finishing this project, I really like your loader and the design is quite good.

  By the way in firefox when you click on it, it does not load a new phrase and if I am not mistaken it is because the first one is saved in the cache, therefore when using the fetch I recommend you to see its second parameter, as well as in the first one it receives the url, in the second one you can pass options and you could pass fetch('https://api.adviceslip.com/advice', { cache: 'no-cache' }), so that it is not saved.

  That if I recommend you to review your report generated by frontend mentor, you have many errors that are simple to solve from not using the attribute fill-rule, to add to the button the attribute aria-label (Since by accessibility issues it should not only contain an image, it should also contain a text since by default we put text to the buttons but when not placing it you should put that attribute so that the screen reader can read it). Try to correct all these until every time you generate a new report it comes out with 0 errors.

  I hope my comments are helpful.

  Good Coding!

  1

  ---

  

  Mounir Moutawakil•420

  @mounir-m4Posted over 2 years ago

  @Sdann26 Hi Danilo thank you for your feedback I will fix those HTML errors soon but about the first issue, it's from the API itself because you have to wait 2 seconds to fetch a new one thank you again

  0