Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

React Advice Generator

@NathanYee412

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

P
Daniel 140

@obriedan

Posted

Hey Nathan,

There should be the linebreak in the starter pack, it's in the assets folder.

Is there a reason you have three <br /> tags? If you're trying to create space, consider margin or padding instead.

Another small tip, you may want to destructure the props you send into your 'Advice.js' component.

function Advice({number, quote}) {

..... rest of function 
}
    

Doing this means you only grab the props you need, and you don't need to use props.number or props.quote in your JSX.

Marked as helpful

0

@NathanYee412

Posted

@obriedan Thank you for the tips! I've implemented every suggestion you had.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord