Skip to content
Submitted 8 months ago

React

mbalali63ā€¢150
@mbalali63
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social links profile
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I just tried to implement this project with React, to practice my skills in using React and defining and handling with components and building process. It takes more time than if I made it with pure HTML-CSS, but I think it was good.

What challenges did you encounter, and how did you overcome them?

The first challenge was showing images in React apps, that I found the solution was to require the image. The other challenge was to deploy site on cloudfare, and I resolved it by building the app locally and then upload the build folder on cloudfare. I will appreciate any guidance for connecting react app which is uploaded on github to the cloudfare. My problem was that cloudfare arose a bunch of deprication warnings and errors. which I didn't know how to resolve them.

What specific areas of your project would you like help with?

I need help on semantic structuring of the project and also about how to connect github repo of this project to cloudfare

Community feedback

  • Graceā€¢31,090
    @grace-snowPosted 8 months ago

    The html needs changing on this.

    • The top part is not a distinct section, just use a div.
    • The location is not a heading, it's a paragraph.
    • the links are links not buttons. They would navigate somewhere.
    0
    mbalali63ā€¢150
    @mbalali63Posted 8 months ago

    Thank you @grace-snow for the useful comments

    0
  • Daniel šŸ›øā€¢44,250
    @danielmrz-devPosted 8 months ago

    Hello, @mbalali63!

    Your project is looking fantastic!

    I'd like to suggest a way to make it even better:

    • Using margin isn't always the most effective method for centering an element.

    Here's a highly efficient approach to position an element at the center of the page both vertically and horizontally:

    šŸ“Œ Apply this CSS to the body (avoid using position or margins in order to work correctly):

    body {
    min-height: 100vh;
    display: flex; 
    justify-content: center;
    align-items: center;
}

    I hope you find this helpful!

    Keep up the excellent work!

    0
    mbalali63ā€¢150
    @mbalali63Posted 8 months ago

    Hi @danielmrz-dev Your suggestion is great. thank you so much for the support and guidance.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord