Skip to content
Submitted over 1 year ago

Raw HTML CSS and JS

vishwjeet thakur•30
@ervishwa
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Advice generator app
  • HTML
  • CSS
  • JS
  • API
2junior

Design comparison

SolutionDesign

Solution retrospective

I tried my best. I know it is not perfect but I am trying to improve my skills...I will be glad if you suggest my anything according to you..

Community feedback

  • Tushar Biswas•4,080
    @itushPosted over 1 year ago

    Congratulations on completing the challenge! 🎉

    Nice attempt :)

    • To center an element within its parent, you can use the following CSS properties on the parent:
    display: flex;
align-items: center;
justify-content: center;
min-height: 100vh;

    OR

    display: grid;
min-height: 100vh; 
place-items: center;
    • Please make sure the element you want to center has a smaller height and width.

    In my projects:

    • I always start with mobile-first workflow.
    • I use at least one main element for a page (entire content goes into the main, if I'm not using header & footer), and avoid divs as much as possible and use section and article element wherever I can.
    <body>
<main>
All content 
</main>
</body>

    • I Use relative units as much as possible and avoid absolute units whenever possible.

    • If you are someone who is just starting out with front-end development, I strongly suggest starting with the QR code component project. Also in the challenges page you may filter by (Newbie, HTML&CSS) sort by (easier first) to select projects that will help you solidify your foundation. To avoid any potential knowledge gap⚠️ please first solidify HTML, CSS, JS fundamentals, make few projects only with the trio and then move on to any framework or library.

    • I remember when I started out, I made countless mistakes and spent long hours searching for solutions. But hey, you don't need to go through the same struggles! 🙌 To help you shorten the learning curve, I recommend going through the following articles. They contain valuable insights that can make your journey smoother:

    📚🔍 12 important CSS topics where I discuss about css position, z-index, box-model, flexbox, grid, media queries, mobile-first workflow, best practices etc. in a simple way.

    📚🔍 11 important HTML topics where I discuss about my thought process and approach to convert a design/mock-up to HTML along with important topics like block and inline elements, HTML Semantic Elements.

    I hope you find these resources somewhat helpful in your coding adventures! 🤞

    I'm eagerly looking forward to seeing the amazing projects you'll create in the future! 🚀💻

    Keep up the fantastic work and happy hacking! 💪✨

    Marked as helpful
    1
    vishwjeet thakur•30
    @ervishwaPosted over 1 year ago

    @itush thanku so much for u valuable time sir and advice..

    1
    Tushar Biswas•4,080
    @itushPosted over 1 year ago

    @ervishwa

    You are most welcome!

    We all get better with practice, you got this 💪

    Always happy to help😁

    BTW: It would motivate me to provide quality support like this to the community, if you could spare a moment and give my GitHub pinned projects a ⭐️ star.

    0
  • Lee•230
    @LeeConnelly12Posted over 1 year ago

    Good job! the colors and positioning look correct.

    However, I've noticed you're adjusting the position of your <body> down with this CSS to vertically center the quote box on the page.

    body {
position: relative;
top: 222px;
}

    You're also setting your <body> as grid and centering items within it.

    body {
display: grid;
place-items: center;
}

    By default, the <body> is the height of the content inside of it, if you inspect the <body> on your page you'll see that it's only about 416px tall.

    A more responsive way to vertically center the quote box would be to make the <body> the full height of the screen and allow the body's grid to vertically center the items inside of it.

    body {
min-height: 100vh;
margin: 0;
}

    Finally, you can remove the position relative and top CSS properties

    body {
position: relative;
top: 222px;
}

    Now, on screens with smaller heights, the quote box will move to be in the center instead of a fixed position.

    Marked as helpful
    1
    vishwjeet thakur•30
    @ervishwaPosted over 1 year ago

    @LeeConnelly12 okk lee thanku for the suggestions bro..

    0
  • Aimal Khan•2,260
    @Aimal-125Posted over 1 year ago

    In your css code, increase the height of 120 or 150vh by using media query with max-height: 400px; so that your web app looks good on small heighted screens as mine samsung j3.

    1
    vishwjeet thakur•30
    @ervishwaPosted over 1 year ago

    @Aimal-125 okk bro thanks for suggestion.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord