Design comparison
Solution retrospective
Some added practice for CSS FlexBox and Grid
Community feedback
- @IkuewumiPosted over 1 year ago
Hi there👋. Really nice project🎊. It's almost like the design exactly. But here are some tips to improve it:
-
Accessibility issues: I know having to worry about accessibility is a real pain, and I've not completely mastered it yet, but a simple point in bettering your accessibility is using correct heading levels: namely speaking there should only be one h1, and then any h2s should be after that, and so on (increase heading levels by one), and semantic elements. So, some examples in your code, the first paragraph could be a small tag, the h5 could be a paragraph tag, and the price could be a strong tag
-
This is quite minor, but on the image, on larger screens, you could set the border radius to be exactly like the design like so:
img { border-top-left-radius: 1vmax; border-bottom-left-radius: 1vmax; }
Feel free to ask any questions ❓
Happy coding, Ayobami
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord