Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Rating form created using React and Tailwind

Jimmy Wu 180

@jameswu49

Desktop design screenshot for the Interactive rating component coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


First time posting! Would appreciate any feedback on how it looks and whether there are any areas of improvement I can work on. Thank you!

Community feedback

wannacode 680

@kwngptrl

Posted

Nice work! As it is now, if I click on 'submit' without selecting a rating it would still go through and show 'you selected 0 out of 5'. If you could show a message like 'please select a rating' or some such, and not let it pass through it'd be great.

Also, in mobile mode, the paragraph after 'thank you' is very close to both edges of the container. You could put some padding on either side.

0

Jimmy Wu 180

@jameswu49

Posted

Thanks for the feedback! Updated with a message when the user doesn't pick a rating! @kwngptrl

0

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

COMPONENT MEASUREMENTS 📐:

  • The h-screen utility class is used to define height: 100vh, But we want to use min-height: 100vh for section instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.
  • For example; if we set height: 100vh then the section will have 100vh height no matter what. Even if the content spans more than 100vh.
  • But if we set min-height: 100vh then the section will start at 100vh, if the content pushes the section beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.
  • So we want to use min-h-screen utility class to define min-height: 100vh

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

0

Jimmy Wu 180

@jameswu49

Posted

Makes total sense! Thanks for the feedback! @0xAbdulKhalid

0

@0xabdulkhaliq

Posted

@jameswu49 Glad you found it helpful ! 🤠

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord