Rating Component page

Community feedback

• 

  Philip Droubi•575

  @Philip-DroubiPosted over 1 year ago

  Congratulation on completing this challenge.

  Here are some tips you can do to improve your solution.

  • First for the page body it's better to replace the margin with padding .WHY? To not get that annoying page scroll.

  body{
  /*margin:1.5rem*/ 
  padding: 1.5rem;
  }
  

  • For the main-container doing this will make it look better on all screens.

  body .main-container, body .thank-you {
  width: min(90%, 390px);
  min-width: 200px;                  
  }
  

  • For the h1 inside the main-container I think adding some margin will make it look better.

  body .main-container h1 {
  margin: 18px 0 10px;               
  }
  

  • Finally, don't forget to add validation when clicking on the submit button, as I can click it without setting a value.

  Hope this helps you :)

  Marked as helpful

  3

  ---

  

  Steve•1,170

  @peanutbutterjllyPosted over 1 year ago

  @Philip-Droubi

  very good recommendations! I came to highlight the .main-container change, specifically the width like you pointed out.

  good eye on the other change as well.

  1

  

  Philip Droubi•575

  @Philip-DroubiPosted over 1 year ago

  @peanutbutterjlly Thanks !😃

  0