Rating component [HTML/SCSS/JS] + animations

Community feedback

• 

  Yuliya•230

  @AmbrollaPosted over 2 years ago

  Hello Adam!

  First, good job on your code and for trying! Second, I try to do my best following directions (answering your question about color gradient). So, yes, I think it is important. :) Third, there are some files in your github repo that I would include in the .gitignore. I recommend you reading about it! For example, you don't need to include style-guide :) And I'm a bit confused what is .css.map is, but I'll google it later.

  Fourth, I would suggest instead of this: <div id="1" class="number" onclick="ratCilcked(this.id)">1</div> <div id="2" class="number" onclick="ratCilcked(this.id)">2</div> <div id="3" class="number" onclick="ratCilcked(this.id)">3</div> <div id="4" class="number" onclick="ratCilcked(this.id)">4</div> <div id="5" class="number" onclick="ratCilcked(this.id)">5</div>

  Use event-target and event listener.

  1
• 

  Mustafa DEDE•130

  @mustafadedePosted over 2 years ago

  Hi Adam! Your button have a border but design not. You should delete your border in your css file like border: 0;

  0

  ---

  

  Adam•60

  @VorczuPosted over 2 years ago

  @mustafadede fixed, thanks for feed :)

  0