Rating Component

Community feedback

• 

  Dylan Heslop•1,570

  @dylan-dot-cPosted 15 days ago

  Well done completing this challenge. There are a few things you can improve on.

  • There's a way to reduce the js code you have. If you make the ratings a form where each is a radio button and used the label to customize it with css and add a tabindex to make it accessible you could make use of properties like input type, label, for, name, value in the radios. If you specify an action attribute on the form say action='/rating.html' the data will automatically passed to the URL of that page in the format name=value and you can use JS to get that value and use it on that page. This will reduce your js to from 50+ to like 5 or less lines of code.
  • You forgot to use the custom font in the style guide, you can learn how to get it done and import it from Google fonts and use it in your css file.
  • normally when I don't have the designs I used like 300/320px for the containers, so you can try that.
  • also, try to heading elements that are in proper order h1, then h2 then he so you don't really need to put the text as a h6, just use a p tag.

  It would be good to complete the instructions in the readme template and and paste it into readme.md because it helps you to remember some stuff you've done and helps you improve your documentation skills, which is really important in programming which most ppl overlook

  That should be itz all the best on the updates

  0