Design comparison
SolutionDesign
Solution retrospective
Hey everyone I would like some feedback. cheers!
Community feedback
- @aishwarya-maliPosted over 1 year ago
Hello DECLAN,
Congratulations on completing the challenge! You've done a great job. 👏🎉
I wanted to provide you with some suggestions to improve the user experience on your project:
- Firstly, it would be great if you could make the website mobile responsive so that users can easily access it on their phones or tablets.
- Secondly, I noticed that the ratings and the content above them are not aligned properly according to the design. It would be best to fix this issue to enhance the website's visual appeal. If you have any doubts or need any assistance in implementing these suggestions, please don't hesitate to reach out to me.
Happy Coding! 😊
0@engelbrechtzPosted over 1 year ago@aishwarya-mali
are there ways to make my javascript better?
0@aishwarya-maliPosted over 1 year ago@DevDeclann There are some minor areas of improvement that I would suggest are:
- You should remove any unused code to make the codebase cleaner.
- The btnContainer.addEventListener("mouseover", () => {}) listener appears to be for event delegation, which is not needed in this case as the buttons are already being selected with document.querySelectorAll(".button").
- It would be better to listen to the click event on the submit button and call submitResult() from there, instead of calling it directly.
If you have any doubts or need any assistance in implementing these suggestions, please don't hesitate to reach out to me.
Happy Coding! 😊
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord