Abdul Khaliq 🚀• 72,660
@0xabdulkhaliq
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- This solution generates accessibility error reports due to incorrect usage of
semanticmarkup
- So fix it by replacing the
<section class="container-background">with semantic element<main>along with<div class="attribution">with semantic element<footer>to improve accessibility and organization of your page.
- What is meant by landmark elements ?, They used to define major sections of your page instead of relying on generic elements like
<div>or<span>
- They convey the structure of your page. For example, the
<main>element should include all content directly related to the page's main idea, so there should only be one per page
- And, the
<html>element must have a lang attribute with valid value, so fix it by<html lang="en">
I hope you find it helpful ! 😄 Above all, the solution you submitted is great
Happy coding!
1
