Random advice API

Community feedback

• 

  Byron•2,290

  @byronbyronPosted over 2 years ago

  @Abrosss Looks good!

  Your question is probably one for whoever designed it. I went with a fixed width, but I don't think it matters too much.

  Few html/accessibility issues:

  Your <section class="page"></section> element is probably better off being a <main class="page"></main> (Document should have one main landmark)

  Also need a <h1> element somewhere inside your <section class="container"> (Page should contain a level-one heading)

  Marked as helpful

  2

  ---

  

  Abrosss•440

  @AbrosssPosted over 2 years ago

  @byronbyron Thank you so much!

  0
• 

  Omar M.•270

  @OmarMAttia7Posted over 2 years ago

  Hey, good job you did there 👍.

  Like @byronbyron said your question is not technical it's more concerned with design.

  But in case you want to make it a fixed width you should go with a percentage for smaller screens and a reasonable max width for larger ones. If your component is a flex item use vw instead of percentages.

  Marked as helpful

  1

  ---

  

  Abrosss•440

  @AbrosssPosted over 2 years ago

  @hazel79 Thank you so much! I will try to make a fixed width too:)

  0