Quick QR code component solution

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 11 months ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  CSS 🎨:

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. Resource 📘.

  • You should use the box-sizing: border-box property to make the width and height properties include the padding and border of the element. This will make it easier to calculate the size of an element. You can read more about this here 📘.

  • Use min-height: 100vh instead of height. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.

  CSS Reset 🔄:

  • You should use a CSS reset. A CSS reset is a set of CSS rules that are applied to a webpage in order to remove the default styling of different browsers.

    CSS resets that are widely used:

    • Reset CSS
    • "My Custom CSS Reset" by JoshWComeau

  I hope you find it useful! 😄

  Happy coding!

  Marked as helpful

  2

  ---

  

  Aron Snekkestad•110

  @aronsnPosted 11 months ago

  Hey @MelvinAguilar, many thanks for gold feedback!

  I applied these changes and have made a new deploy. Will be doing from now on!

  Feel free to check out the solution now. I think it looks much more similar to design than before.

  Best, Aron

  0
• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 11 months ago

  Hello @fuzzboii!

  Your solution looks great!

  I have just one suggestion:

  • I think there are more tags than necessary on this one. You used main, article and a div. Unless you have a specific reason for that, you could've used just the main tag, since the card is all we have on the page.

  The <article> tag would make more sense if the card was part of a bigger website (it certailny would in real world).

  I hope it helps!

  Other than that, you did an excellent job!

  Marked as helpful

  1

  ---

  

  Aron Snekkestad•110

  @aronsnPosted 11 months ago

  Hey @danielmrz-dev,

  That makes sense. Your right. I think was making things much more difficult for myself than it should be.

  Thank you for pointing this out! I have deployed the new changes.

  Best, Aron

  1