QRsummary card

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • The section element is not meant to use here, because it cannot define landmark of a webpage

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
  • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
  • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <section class="card"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Joezzyongit•30

  @JoezzyongitPosted over 1 year ago

  Hi, @0xAbdulKhalid thank you for the feed back, I just retouched my work but I'm having trouble with the mobile screen size can you please take a look at my code if you can help me out

  0

  

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  @Joezzyongit, yeah sure i reviewed your css rules and i came up with a solution.

  @media only screen and (max-width: 600px) {
  <-- Mobile View  --->
  }
  

  • We are writing for 600px which ensures all mobile devices, because so many peoples will use 300px to 420px these sizes are only suitable for iphone se like mobile models.

  ---

  • Now your problem has been cleared.

  ---

  • If this feedback helps you then please support my contribution by providing as helpful!, it will encourages me a lot

  ---

  Hope am helpful!

  Marked as helpful

  0

  

  Joezzyongit•30

  @JoezzyongitPosted over 1 year ago

  @0xAbdulKhalid Thank you very much, this cleared all my problems

  0