qr_frontend mentor

Community feedback

• 

  Bryan Li•3,530

  @Zy8712Posted over 1 year ago

  Looks pretty good. Some things I suggest you add if you want your code to appear slightly more similar to the original design:

  body { 
  min-height:100vh; /* this makes your box vertically align to the center */
  background-color:  hsl(212, 45%, 89%);
  }
  

  .modificador h1{
  text-align: center;
  }
  

  .modificador p {
  text-align center;
  }
  

  One other thing is that I would suggest you to use <h2> instead of <h1>. Besides that it looks like you a firm grasp on the fundamentals 👍.

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • You already using Flexbox for layout, but you didn't utilized it's full potential. Just add the following rules to properly center the component.

  ---

  body {
  min-height: 100vh;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  body {
  margin: 1.25rem;
  margin-left: auto;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  roodhouse•520

  @roodhousePosted over 1 year ago

  Hey. Great job! You have the spacing and padding/margins down really well. IMO you should utilize more container divs to help with the styling. For instance if you were to drop a <div> <div> <h1> then you would be able to manipulate the 2 higher up divs before you touched the h1. This would allow you to then see what styling is left to implement on h1. You might find one or two things or nothing is needed at all. Personally, I attempt to place the bulk of my styling on divs and if needed, then I style the data directly. Anyway, great start and keep it going!

  0