Design comparison
Solution retrospective
help me with best practices ?
Community feedback
- @HassiaiPosted over 1 year ago
To center .qr-component on the page using flexbox, replace the height in .container with min-height: 100vh.
Give .img a max-width of 100% for a responsive image.
Give .info a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1. Give p a margin-top or h1 a margin-bottom value for the space between the text.
Reduce the max-width of .qr-component for it to be equivalent to the width of the design.
max-width: 350px
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord