qr-component-tailwindcss

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1
• 

  Apah•280

  @apah-devPosted over 1 year ago

  Great work!

  I noticed you didn't use the image provided in the images folder I'm guessing you either didn't see the file or you decided to be creative with the project and use your own image.

  If you didn't see the images folder, it is downloaded with the project challenge and contains all the necessary images. There's also the styleguide.md which contains the fonts, font-weight, font-size, colors. I hope this helps

  1

  ---

  

  Sebastian•150

  @PerfekTyPosted over 1 year ago

  @apah-dev I wanted to be creative and make my own QR image which will be forwarding to my github profile :)

  0

  

  Apah•280

  @apah-devPosted over 1 year ago

  @PerfekTy Perfect then! You definitely did a great job

  Marked as helpful

  1