qr-component-main using CSS

Community feedback

• 

  Aimal Khan•2,260

  @Aimal-125Posted over 1 year ago

  In your CSS code, increase the height of body element to 120 or 150vh by using media query with max-height: 400px; so that your solution look good on screens with small heights.

  Marked as helpful

  1

  ---

  

  S M Bilal Chishti•20

  @chishticodesPosted over 1 year ago

  @Aimal-125 Thanks a lot for your suggestion and I will be implementing the changes to make the solution responsive for mobile screens.

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ARE NOT PROPERLY USED ⚠️:

  • This solution consists incorrect usage of <h3> so it can cause severe accessibility errors due to incorrect usage of level-three headings <h3>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • In this solution there's <h3> element which is this <h3>Improve your...</h3>, you can preferably use <h1> instead of <h3>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely

  ---

  • So we want to add a level-one heading to improve accessibility

  ---

  • Example: <h1>Improve your front-end skills by building projects</h1>

  ---

  • If you have any questions or need further clarification, and feel free to reach out to me.

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  S M Bilal Chishti•20

  @chishticodesPosted over 1 year ago

  @0xAbdulKhalid

  Frontend mentor also pointed out that I should have a <h1> tag on my page which I was unaware prior to submitting my solution. Its really nice that I am learning html semantics as I am improving my css skills.

  Thanks a lot brother for that detailed analysis.

  0