QR-component--main

Community feedback

• 

  Engjell Bakiasi•130

  @engjell17Posted about 2 years ago

  I like this solution for the challenge. Here are a few suggestions I've made that you can consider in the future if you're looking to improve the solution further:

  Instead of using pixels in font size with --fs: 15px;, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference. The alt attribute should not have hyphens. Use margin: 0.938rem or margin: 15px in the .card selector so that it has some space when viewed on mobile devices. I hope those tips will help you. very good!!!

  Marked as helpful

  1
• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @lazza24 👋, good job on completing this challenge! 🎉

  I like this solution for the challenge. Here are a few suggestions I've made that you can consider in the future if you're looking to improve the solution further:

  • Instead of using pixels in font size with --fs: 15px;, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.
  • The alt attribute should not have hyphens.
  • Use margin: 0.938rem or margin: 15px in the .card selector so that it has some space when viewed on mobile devices.

  I hope those tips will help you.

  Good job, and happy coding!

  Marked as helpful

  1