Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR-component--main

Lazar Risticโ€ข 80

@lazza24

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Engjell Bakiasiโ€ข 130

@engjell17

Posted

I like this solution for the challenge. Here are a few suggestions I've made that you can consider in the future if you're looking to improve the solution further:

Instead of using pixels in font size with --fs: 15px;, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference. The alt attribute should not have hyphens. Use margin: 0.938rem or margin: 15px in the .card selector so that it has some space when viewed on mobile devices. I hope those tips will help you. very good!!!

Marked as helpful

1

@MelvinAguilar

Posted

Hi @lazza24 ๐Ÿ‘‹, good job on completing this challenge! ๐ŸŽ‰

I like this solution for the challenge. Here are a few suggestions I've made that you can consider in the future if you're looking to improve the solution further:

  • Instead of using pixels in font size with --fs: 15px;, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.
  • The alt attribute should not have hyphens.
  • Use margin: 0.938rem or margin: 15px in the .card selector so that it has some space when viewed on mobile devices.

I hope those tips will help you.

Good job, and happy coding!

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord