qr-component-main

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Jitesh, Congratulations great job!

  I have a few suggestions for you:

  • add main tag and wrap the card for Accessibility
  • try to remove all margin from section and use flexbox to the body for center the card. Read here -> flex guide
  • also set heigth of body to 100vh because Flexbox aligns to the size of the parent container.

  In the end to make it look as close to the design as possible add:

  • text-align: center; to bottom-text class
  • padding-inline: 1rem; to span element
  • replace span element with p

  Hope this help and happy coding!

  Marked as helpful

  2

  ---

  

  Jitesh Kumar Sahoo•315

  @Jitesh117Posted almost 3 years ago

  @denielden Thanks for the feedback! I really appreciate the time you took to give these tips

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  @Jitesh117 You are welcome! And don't forget to mark my comment as helpful if you have been driving, thanks :)

  Marked as helpful

  1