Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi Jitesh, Congratulations great job!
I have a few suggestions for you:
- add
main
tag and wrap the card for Accessibility - try to remove all
margin
from section and use flexbox to the body for center the card. Read here -> flex guide - also set
heigth
of body to100vh
because Flexbox aligns to the size of the parent container.
In the end to make it look as close to the design as possible add:
text-align: center;
tobottom-text
classpadding-inline: 1rem;
tospan
element- replace
span
element withp
Hope this help and happy coding!
Marked as helpful2@Jitesh117Posted over 2 years ago@denielden Thanks for the feedback! I really appreciate the time you took to give these tips
1@denieldenPosted over 2 years ago@Jitesh117 You are welcome! And don't forget to mark my comment as helpful if you have been driving, thanks :)
Marked as helpful1 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord