QR-component using HTML and CSS

Community feedback

• 

  Raul Rebolledo•230

  @rrebolledo90Posted over 1 year ago

  Greetings, after looking over your code on dev-tools I marked some suggestions for you. I noticed that you used position-absolute to center your container. However, one easy way to center your container is to use the margin: 0 auto trick (as you can see below, this gives you the same results as using position-absolute and transform:translate).

  Container {

  margin: 0 auto;

  display: flex;

  flex-direction: column;

  width: 350px;

  border-radius: 40px;

  background-color: hsl(0, 0%, 100%);

  }

  Now, another reason why you can't move your container down is because you don’t have enough height on your parent element (in this case main being the direct parent). If you add the following it moves your container down.

  Main {

  height : 100vh;

  Display: flex;

  Align-items: center;

  }

  Hope this helps.

  Marked as helpful

  0

  ---

  

  Emmanuel Afrifa•240

  @Emmanuel-AfrifaPosted over 1 year ago

  @rrebolledo90 Thank you very much

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS NAMING CONVENTIONS 🚫:

  • Looks like the naming conventions you used for css needs to be improved a lot, you can take a look at BEM Naming Convention.

  ---

  • BEM helps to create modular, reusable, and maintainable code. With BEM, you can easily identify which styles apply to which elements, making it easier to modify and update your CSS.

  ---

  • BEM naming conventions provide a clear structure and naming hierarchy for your CSS classes. This makes it easier to read and understand your code, even for other developers who are not familiar with your project.

  ---

  • BEM allows for more granular control over styling. With BEM, you can target specific elements within a block and modify their styles without affecting other elements or blocks on the page.

  ---

  • BEM helps to avoid naming collisions and specificity issues. By using a consistent naming convention, you can avoid accidentally overwriting styles or causing specificity issues that make it difficult to style your elements.

  ---

  • BEM makes it easier to collaborate with other developers on larger projects. By using a shared naming convention and structure, you can ensure that everyone on the team is using a consistent approach to styling, which reduces confusion and errors.

  ---

  • This article on CSS-Tricks provides a beginner-friendly introduction to BEM and explains the key concepts and benefits of using BEM.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  Congratulations on completing the challenge! Your hard work and dedication are truly admirable. As you continue to hone your skills, here are a few suggestions that may be helpful:

  1. Keep practicing and learning new things. The more you challenge yourself, the more you'll grow as a developer.

  2. Seek feedback from others. It's always helpful to get a fresh perspective on your work and learn from constructive criticism.

  3. Collaborate with other developers. Working with others can help you learn new techniques and improve your coding skills.

  Again, congratulations on completing the challenge, and I wish you continued success in your coding journey! 😁

  Marked as helpful

  0