QR-component card with css-animation

Community feedback

• 

  Sounak Mukherjee•560

  @kanuosPosted over 1 year ago

  Hi Lesya, congrats on your first submission. The UI structure looks nice, however I've few questions/suggestions -

  1. Why is the card heading replaced by random lorem ipsum texts?
  2. Same goes with the card description
  3. Imagine a scenario - you visited a website where you are to scan a QR code (preferably by a phone camera). Would you like to hover the card before you can scan? There's no need for this effect. It is counter productive as it beats the purpose of a Quick Response card. The card rotation using perspective property is cool but kinda goes against the UX of this app.

  As far as the semantic HTML and BEM naming conventions are concerned - you aced it! At a quick glance, I thought it was perfect. Keep up the good work :)

  Marked as helpful

  2

  ---

  

  Lesya Stulkivska•10

  @LegritoPosted over 1 year ago

  @kanuos thanks for considering my solution and for so meaningful feedback! 1&2 - I thought only styles matters, not the content, as I don't have an access to figma file. 3 - Agree with your concerns, I redo the concept, but still want to add animation, now with additional space for extra cta or description. Overall, thanks a lot:)

  1
• 

  Loai Esam•670

  @LoaiEsam37Posted over 1 year ago

  you have to put your <div class="qr__wrap"> tag inside a <main> tag so that it becomes easier for screen readers to know where is the main content and you can also use something like <nav> , <footer> and <sidebar> tags for the same reason.

  Marked as helpful

  0

  ---

  

  Lesya Stulkivska•10

  @LegritoPosted over 1 year ago

  @LoaiEsam37 thank you, for considering my solution and for your feedback! Agree, it's better to use semantic tags to increase accessibility:)

  0