Skip to content
Submitted 8 months ago

QR-Code-Web

Marlon•10
@Marlon2123
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

That I could do it myself without watching a tutorial

What challenges did you encounter, and how did you overcome them?

to center the whole object, paid attention on the flex, and how I used it

What specific areas of your project would you like help with?

get cleaner in the code

Community feedback

  • Harsh Kumar Dwivedi•740
    @Harsh-Kumar-DwivediPosted 8 months ago

    Hi @Marlon2123 ,

    I think you can make your markup more semantic and short. Consider replacing <div> inside <body> by <main> element and also removing <section> element as it is not required.

    You can prefer removing classes from <h1 class="header"> and <p class="text"> as you haven't used them and also they are not needed.

    Hope these suggestions were helpful !

    Nice work 👍!

    Happy Coding !

    Marked as helpful
    1
    Marlon•10
    @Marlon2123Posted 8 months ago

    @Harsh-Kumar-Dwivedi your right, I will go ahead and look into, and try to make it more semantic, thanks so much for the feedback :)

    0
    Harsh Kumar Dwivedi•740
    @Harsh-Kumar-DwivediPosted 8 months ago

    @Marlon2123

    Glad you liked suggestions !

    If you found my suggestions helpful, please consider marking it as "Marked as helpful".

    Happy Coding !

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord