QR-Code-Scanner-Using-HTML&CSS

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have other suggestions about your code that might interest you.

  HTML 📄:

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io

  CSS 🎨:

  • Setting the font-size to 62.5% can attract compatibility issues with third-party libraries or plugins. You can read more about this with this two lectures:

  1. The Surprising Truth About Pixels and Accessibility - The 62.5% trick
  2. A comment on the 62.5% trick

  Credit to grace-snow and vanzasetia for pointing this out.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1

  ---

  

  Yagyesh mani Tripathi•140

  @YagyeshMani1498Posted almost 2 years ago

  @MelvinAguilar Thanks for your suggestion. i will apply this and i hope to get advice in future also.

  1
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  to center .main-container on the page, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

  To center .main-container on the page using flexbox:
  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  To center .main-container on the page using grid:
  body{
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  Give h1 the same font-size as p .

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  Yagyesh mani Tripathi•140

  @YagyeshMani1498Posted almost 2 years ago

  @Hassiai thanks for your suggestions ☺☺,acutally i didn't use Flex-Box or CSS-Grid Because i just want to use some basics styling, but i will definately use your suggestions in my next project.

  0