Design comparison
SolutionDesign
Community feedback
- @SamadeenPosted over 2 years ago
Hey!! Cheers 🥂 on completing this challenge.. .
Lets firstly work on your accessibility issues.
Document should have on main landmark
basically means your html should be structured more semantically and the correct format should be your<header>......</header>
followed by your<main>......</main>
and lastly your<footer>....</footer>
hence you should use<main class="container">
instead of<div class="container">
.Page should contain a level-one heading
basically means yourhtml
should have ah1
it aid navigation hence<h2>Improve your front-end <br> skills by building projects</h2>
should be<h1>Improve your front-end<br> skills by building projects</h1>
and you should also go down orderly when you are using the headings h1 down to h2 down to h3 and so on.Images must have alternate text
- Its hard for screen readers to pick up messages from images withoutalt
text.. Its always advisable to includealt
text to aid screen reader
This should fix most of your accessibility issues.
- You should increase your
border-radius
to make it more curvy. - You should also use
rem
em
%
instead ofpx
when measuring.. It improves responsiveness
. Regardless you did amazing... hope you find this helpful... Happy coding!!!
NAIJA TO THE WORLD!!!
Marked as helpful0@PreciousOritsederePosted over 2 years ago@Samadeen Thank you. I'll look into these
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord