Qr-code-page-using-plain-html-and-css

Community feedback

• 

  Stefan Cristian•80

  @xSStephenPosted about 2 years ago

  Hello Osauyi! Great solution for this challange!

  Regarding your question, you can use the following code to center the parent container in the middle of the screen using flexbox.

  display: flex;
   justify-content: center;
   align-items: center;
   min-height: 100vh;
  

  Marked as helpful

  1
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi @Osauyi, congratulations on your solution!

  From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  1.Remove the margin and add min-height: 100vh to make sure the body size is the screen height ever:

  main {
      display: flex;
      justify-content: center;
      align-items: center;
      /* margin-top: 80px; */
  }
  
  body {
      min-height: 100vh;
      background-color: hsl(212, 45%, 89%);
      font-family: 'Outfit', sans-serif;
      display: flex;
      justify-content: center;
      align-items: center;
      flex-direction: column;
  }
  

  2.Clean your code by removing some unnecessary divs, most of the content can stand alone without a div. Use div only for blocks that need a special alignment or the content needs a special positioning.

  3.Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  Victor imafidon•590

  @OsauyiPosted about 2 years ago

  @correlucas thank you so much

  0