QR-Code-Page

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 9 months ago

  Hello @GeorgeKandelaki!

  Your solution looks great!

  I have a couple of suggestions (about semantic HTML) for improvement:

  📌 First: Use <main> to wrap the main content instead of <div>.

  Think of <div> and <span> in HTML like plain boxes or placeholders. They're handy for holding content, but they don't tell us anything about what's inside or what it's meant for on the webpage.

  📌 Second: Use <h1> for the main title instead of <h2>.

  Unlike what most people think, it's not just about the size and weight of the text.

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> defines the most important heading.
  • <h6> defines the least important heading.
  • Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  1

  ---

  

  George Kandelaki•610

  @GeorgeKandelakiPosted 9 months ago

  @danielmrz-dev Thanks for telling me my mistakes. I will try my utmost to type more semantic HTML.

  1
• 

  Amer•360

  @amerrikaPosted 9 months ago

  Hi, GeorgeKandelaki

  Nice solution. I think you don't need to have a container div. You can just set max-width on your main-content div to get the same effect.

  .main-content {
      max-width: 40rem;
      padding: 2.4rem 1.8rem;
      border-radius: 1.5rem;
      background-color: white;
      box-shadow: 0 0 20px rgba(0, 0, 0, 0.3);
  
      display: flex;
      flex-direction: column;
      align-items: center;
      justify-content: center;
      gap: 2.4rem;
  }
  

  For components like this it is common to use name "card" instead of "main-content".

  I hope this helps you a little

  Best of luck with coding

  Marked as helpful

  1

  ---

  

  George Kandelaki•610

  @GeorgeKandelakiPosted 9 months ago

  @amerrika Thanks I Will try to correct my mistake

  1