Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR_Code_Mentor

konji85 80

@konji85

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

it was not difficult

What challenges did you encounter, and how did you overcome them?

keeping the dimensions between the elements. i didnot know the exact way so i had to estimate

What specific areas of your project would you like help with?

making the page responsive

Community feedback

SIDA 190

@GSida015

Posted

Hello I saw your solution... I went to your site... saw your code... etc

Overall its like medium let me correct you...

1.the container should not be like that you should add that properties to body:

body{
    font-size: 15px;
    max-width: 1440px; 
    background-color:hsl(212, 45%, 89%) ;
    font-family: 'Outfit';
      }
.container{
            max-width: 1230px;
            height: 100%;
            display: flex;
            margin: 0 auto;
            justify-content: center;
            align-items: center;
        }

2.YOU SHOULDN'T DO MARGIN USING %!!! This ruins your whole structure on responsive:

card-container{
    background-color: hsl(0, 0%, 100%); 
    border-radius: 15px;
    padding: 16px;
    display: flex;
    flex-direction: column;
    align-items: center;
    text-align: center;
}

Here you dont need margin because you are already make container position it in center by display flex

3.Is text problem is in responsive text is shortened because you use % in margin... Instead you can:

card-container img{ border: 1px solid moccasin; width: 100%; border-radius: 10px; }
.primary{
     color:hsl(218, 44%, 22%);
     font-weight:700;
     width: here you can provide exact width and control text-align with it;
     font-size: 1.1rem;
}
.secondary{
    color:hsl(220, 15%, 55%);
    font-size: 15px;
    font-weight:400;
    font-size: 0.8rem;
    width: here you can provide exact width and control text-align with it;
}

I hope this helped you

I would appreciate it if you would mark this comment helpful!

Marked as helpful

0
Kate 60

@devknightingale

Posted

Looks good, adding the attribution is an interesting idea I wouldn't have thought to do.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord