qr-code-main-component

Community feedback

• 

  Sebastian•290

  @SebBudynskiPosted 10 months ago

  Hello there 👋. Good job on completing the challenge !

  I have suggestions about your code that might interest you.

  • The 'max-width: 1440px;' property in the 'body' - you don't need this line. I have a larger screen, and as a result, the content is not centered
  • It's a good practice to use 'rem' units instead of pixels for font sizes and dimensions in your content. This ensures better scalability and accessibility.

  I hope it helps!

  Happy coding!

  Marked as helpful

  0

  ---

  

  Tariq Auwal•90

  @TareeqcodesPosted 10 months ago

  Hello@SebBudynski yes I will check on that thanks alot for your time 🙏

  0
• 

  Daniel 🛸•44,270

  @danielmrz-devPosted 10 months ago

  Hello @tariqauwal2020!

  Your project looks great!

  I noticed that you used margin to place the card in the middle of the page. Here's a very efficient (and better) way to center the card:

  • Apply this to the body (in order to work properly, don't use position or margins):

  body {
      min-height: 100vh;
      display: flex;
      justify-content: center;
      align-items: center;
  }
  

  I hope it helps!

  Other than that, great job!

  1

  ---

  

  Tariq Auwal•90

  @TareeqcodesPosted 10 months ago

  Hello @danielmrz-dev yes will check on that thanks for the corrections.🙏

  1