Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

qr-code-main-component

@Tareeqcodes

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please any feedback, suggestion or corrections.

Community feedback

Sebastian 290

@SebBudynski

Posted

Hello there 👋. Good job on completing the challenge !

I have suggestions about your code that might interest you.

  • The 'max-width: 1440px;' property in the 'body' - you don't need this line. I have a larger screen, and as a result, the content is not centered
  • It's a good practice to use 'rem' units instead of pixels for font sizes and dimensions in your content. This ensures better scalability and accessibility.

I hope it helps!

Happy coding!

Marked as helpful

0

@Tareeqcodes

Posted

Hello@SebBudynski yes I will check on that thanks alot for your time 🙏

0
Daniel 🛸 44,230

@danielmrz-dev

Posted

Hello @tariqauwal2020!

Your project looks great!

I noticed that you used margin to place the card in the middle of the page. Here's a very efficient (and better) way to center the card:

  • Apply this to the body (in order to work properly, don't use position or margins):
body {
    min-height: 100vh;
    display: flex;
    justify-content: center;
    align-items: center;
}

I hope it helps!

Other than that, great job!

1

@Tareeqcodes

Posted

Hello @danielmrz-dev yes will check on that thanks for the corrections.🙏

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord