Skip to content
Submitted about 2 years ago

qr-code-frontend-mentor-challange

natalia dragutan•30
@nataliadragutan
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,160
    @MelvinAguilarPosted about 2 years ago

    Hi @nataliadragutan 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉

    Here are some suggestions you might consider to improve your code:

    With semantic tags:

    <body>
   <main class="container">
      . . .
   </main>
   <footer class="attribution">
      . . .
   </footer>
<body>
    • Add descriptive text to the alt attribute of the images. The text must clearly describe the image. The alt attribute enables screen readers to read the information about on-page images and will be displayed instead if an image file cannot load.
    • Use an h1 tag for your solution. The <h1> element is the main heading on a web page. There should only be one <h1> tag per page, and always avoid skipping heading levels; Always start from <h1>, followed by <h2>, and so on up to <h6> (<h1>,<h2>,...,<h6>). The HTML Section Heading elements (Reference).
    <h1>Improve your front-end skills by building projects</h1>
    • The container isn't centered correctly. You can use flexbox to center elements:
    body {
  width: 100%;
  min-height: 100vh;
  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
}

    Additionally, remove the margin to center the image correctly:

    .container {
    .  .  .
    /* margin: 130px auto;
}

.attribution {
    .  .  .
    /* margin: auto; */
}

    Links with more information:

    I hope those tips will help you.

    Good job, and happy coding!

    Marked as helpful
    1
  • natalia dragutan•30
    @nataliadragutanPosted about 2 years ago

    Thank you very much for your comment. Sure I will certainly consider this advice.

    0
  • Faisal Alharbi•330
    @LovelyFaisalPosted about 2 years ago

    Hi! You've done great 💪

    Here are some suggestions to improve your code:

    Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.

    Click here for more information

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord