Skip to content
Submitted about 2 years ago

QRCodeComponent_usingFlexbox

Tauseef Ansari•20
@tausGit
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

hey here is my QRCode challenge solution.... it's kind of incomplete :P Suggestions to improve my Skills is the most that i need... please do give feedbacks on how to improve , what's the best way to approach such projects...

Thanks..

just deployed to netlify

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hello Tauseef, Congratulations on completing this challenge!

    You’ve done really good work here putting everything together, I’ve some suggestions you can consider applying to your code to improve the html markup/semantic:

    You've done the design for the wrong image, when you download the starter files the folder comes with 3 files (preview card, desktop and mobile) you've created the solution based on the preview and you should consider only the mobile + desktop images.

    Remove the background-color from the container and add it to the body to make sure this color background will display it full screen.

    The html structure is fine and works, but you can reduce at least 20% of your code cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.

    <body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    1
    Tauseef Ansari•20
    @tausGitPosted about 2 years ago

    @correlucas thanks a lot lucas for the guidance , will keep these points handy for my other attempts...💕

    1
  • Md5 dalton•1,430
    @md5daltonPosted about 2 years ago

    Hello Tauseef Ansari

    First, let's implement some semantic HTML markup to resolve some of the accessibility issues:

    • Replace this div.main with main element.
    • Replace the p element which is the first child of div.desc with a h1 element.

    Second, to use the provided font, you can use link tag in your index.html or @import statement in your styles.css. I'll demonstrate the latter: @import url('https://fonts.googleapis.com/css2?family=Outfit:wght@400;700&display=swap');, then add this to your styles: body {font-family: 'Outfit', sans-serif;}.

    Finally, adjust some of the styles to make them more efficient:

    • Remove all styles in div.main and div.GlobalContainer.
    • Define them on body tag instead:
    body {
   display: flex;
   align-items: center;
   justify-content: center;
   margin: 0;
   min-height: 100vh;
   background-color: hsl(212, 45%, 89%);
}

    Great effort on submitting your first solution. Wish you the best in your journey in front-end web development 👌

    Marked as helpful
    1
    Tauseef Ansari•20
    @tausGitPosted about 2 years ago

    @md5dalton wow! such a detailed suggestion thanks a lot Dalton... will keep these feedbacks to my next attempt... thanks again... :D

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord