QR-Code-Component-Using-Flexbox

Community feedback

• 

  Muhammadh•1,140

  @Mr-jawPosted almost 2 years ago

  Hello There 👋

  Nice Job on completing the challenge

  HTML 📄

  • replace <div class="attribution"> with the <footer> tag to fix accessibility issues.

  • Instead of using a <div> tag for <div class="front-end-text"> It would be accessibility friendly if you use a header tag, and instead of using a <h1> tag for <h1 class="scan-qr-text"> I prefer using a <p> tag for it since it is a descriptive text.

  CSS 🎨

  • Use relative units such as em or rem for margin, padding, width, and height, and preferably rem for font sizing for responsiveness. avoid using px since it is an absolute unit.

  I like the fact that you used CSS custom properties to assign variables.

  I hope this was something useful 😊

  KEEP IT UP!

  Marked as helpful

  2

  ---

  

  Lance Babiano•20

  @codepap1Posted almost 2 years ago

  @Mr-jaw I'll surely do that on my future challenges and projects. I appreciate your feedback. Thank you so much! 😁

  0