qr-code-components using css custom properties

Community feedback

• Account deleted

  Hi there 👋

  Congratulate on finishing your project 🎉. You did a great job 💡

  I give some suggestions to help you take your project design to the next level 📈😉

  • Remove the height from the .container. In CSS adding height is not good practice until you really need it ⚠. If you remove it from the container it still works and nothing changes, because the height calculated automatically

  Happy coding ☕

  Maqsud

  Marked as helpful

  1
• 

  Caio de Alcantara Santos•250

  @caio-alcantaraPosted almost 3 years ago

  You did a great job! But why didn't use the * selector to remove all the default margin/padding?

  Marked as helpful

  1

  ---

  

  Christ Kevin Touga Watat•270

  @Christ-KevinPosted almost 3 years ago

  @caio-alcantara honestly i copied it in this codepen(https://codepen.io/pen?&editors=110&layout=left) from smolcss(https://smolcss.dev/).

  But I understand your point and I think it's a good idea to use the global(*) selector. I will try this for sure in my next projects.

  Thanks

  1
• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  hay! Christ Kevin Touga Watat Nice work

  1
• 

  Gomes Martins•60

  @gomesemogPosted almost 3 years ago

  Great job my friend! I would second Caio's comment, its very useful. Other thing that I would point is that you centralized all the content, but it should be attribuited just for the card itself. Otherwise, again, great job!

  1
• 

  optimusprime202•1,200

  @optimusprime202Posted almost 3 years ago

  Hey @Christ-Kevin, Tremendous work!

  0