qr-code-components using css custom properties
Design comparison
Solution retrospective
I don't have a particular question on this project but I would be grateful for any suggestions that can make me improve
Community feedback
- Account deleted
Hi there π
Congratulate on finishing your project π. You did a great job π‘
I give some suggestions to help you take your project design to the next level ππ
- Remove the height from the
.container
. In CSS adding height is not good practice until you really need it β . If you remove it from the container it still works and nothing changes, because the height calculated automatically
Happy coding β
Maqsud
Marked as helpful1 - Remove the height from the
- @caio-alcantaraPosted over 2 years ago
You did a great job! But why didn't use the * selector to remove all the default margin/padding?
Marked as helpful1@Christ-KevinPosted over 2 years ago@caio-alcantara honestly i copied it in this codepen(https://codepen.io/pen?&editors=110&layout=left) from smolcss(https://smolcss.dev/).
But I understand your point and I think it's a good idea to use the global(*) selector. I will try this for sure in my next projects.
Thanks
1 - @NaveenGumastePosted over 2 years ago
hay! Christ Kevin Touga Watat Nice work
1 - @gomesemogPosted over 2 years ago
Great job my friend! I would second Caio's comment, its very useful. Other thing that I would point is that you centralized all the content, but it should be attribuited just for the card itself. Otherwise, again, great job!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord