QR-Code-Components

Community feedback

• 

  Vladimir•160

  @VladmidirPosted over 1 year ago

  Good job with the challenge!

  Couple of things I want to say. First, you want all of the page content to be enclosed by landmarks to make it accessible. This challenge requires a<main> element, which you can simply substitute for the <div id="box_of_qrcode">. More on landmarks here.

  Another thing is that you should make a separate file for your styles (e.g. styles.css). This is a small challenge that does not require a lot of css, but normally you want to separate your html from css.

  Hopefully this was helpful!

  Marked as helpful

  1

  ---

  

  Mustakim Choksi•20

  @DevmustakimPosted over 1 year ago

  @Vladmidir Thank You For Your FeedBack. I will try to fix it as soon as possible

  1