Qrcode-component-project

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  There is no need for <div class="body"> and its styling in the css

  Replace <div class="Qr-container"> with the main tag and <h2> with <h1> to make the content/page accessible. click here for more on web-accessibility and semantic html

  Every html must have <h1> to make it accessible. Always begin the heading of the html with <h1> tag wrap the sub-heading of <h1> in <h2> tag, wrap the sub-heading of <h2> in <h3> this continues until <h6>, never skip a level of a heading.

  To center .Qr-container on the page using flexbox, add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body

  body{
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
  }
  

  There is no need for min-height in .Qr-container and increase the padding value. padding:16px which is 1rem/em

  Give .text a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1. Give p a margin-top or h1 a margin-bottom value for the space between the text.

  Give p a font-color of hsl(220, 15%, 55%); for the faded color.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here and here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0
• 

  Ralphdany•170

  @RalphdanyPosted over 1 year ago

  Alright, thanks for everything sir

  0