Qr-Code-Component-Project

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted almost 3 years ago

  Greetings JyteCeo

  • use semantic elements where possible. Instead of having a div with the class of main, it is better to use the main element.
  • A site should have a heading element as well, especially the first level heading element.

  Marked as helpful

  0
• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Awesome work with this one. Viewing your solution, I would suggest the following for you...

  • Inside the .description .description-title rule set, include the text-align: center; and adjust the font size into 1.3em
  • Add text-align:center; in the .description .description-content and add font-size: 15px;
  • Wrap the main-container with specific tag like main and attribution with footer tag for readability

  Once again, great job and Keep it up!

  Marked as helpful

  0
• 

  Web Wizard•5,690

  @rsrclabPosted almost 3 years ago

  Hi, @JyteCeo ~

  Congratulate on your solution to the challenge on FM platform. I have studied your work carefully and learned a lot from it.

  Here are some of the tips I like to provide.

  • Please try BEM for naming element classes. It will help you a lot on bigger projects.
  • Font family is a bit different from design.
  • I hope you to center the card on wider screen. Using display: flex; justify-content: center on parent element can solve this issue.

  If it can help you even a bit, it would be happy to me.

  Cheers ~

  Marked as helpful

  0