qr-code-component-main-project2

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  Hello Nirajan Prasad,

  Excellent work! Congratulation on completing this challenge. Your solution looks great. I have some suggestions regarding your solution if you don’t mind:

  • You can use <main> landmark to wrap the card. HTML5 landmark elements are used to improve navigation.

  • Page should contain <h1>. In this challenge , as it’s supposed to be a part of a whole page, you may use<h1>with sr-only class hidden visually and present for assistive tech users. You should use a <h2> for the .heading.

  • In my opinion, the alternate text should indicate where the Qr code navigate the user : like QR code to frontend mentor.

  • I would not use <section> just for part of the component as <section> is a generic standalone section of a document

  CSS:

  • To center the component on the middle of the page you may use the flex/grid properties with min-height 100vh; to the body. Also you can add a little padding to the body to prevent the card from hitting. No need for absolute positioning

  • Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  • Remember a css reset on every project. That will do things like set the images to display block and make all browsers display elements the same.

  Aside these, Great work on this one. Hopefully his feedback helps.

  Marked as helpful

  1

  ---

  

  Nirajan Prasad•190

  @behubjPosted over 2 years ago

  @PhoenixDev22 Thank You very much, for your lovely comment. I will surely try to improve and try to getting better

  1

  

  PhoenixDev22•16,950

  @PhoenixDev22Posted over 2 years ago

  @behubj Glad it was helpful. Happy coding!

  0