qr-code-component-main with html & css
Design comparison
Solution retrospective
This went well but I still hope there is something in there I could have done better. Please keep your reviews coming. Thank You
Community feedback
- @correlucasPosted over 2 years ago
👾Hello Dennis, congratulations for your first solution!
I liked that you've said you're a lifelong learned, I agree with this philosophy too.
Your solution is really correct and the concept you've used to build is fine, but note that there are some small fixes you can apply to improve it.
1.The component its a little to big in comparison to the design files, try to manage the component with
max-width: 350;and the inner contents respecting 100% of the its width, there's no need to set awidthfor each element inside.2.The correct color for the background is light blue, try this value instead
background-color: hsl(212, 45%, 89%);3.When you build your next challenge first think
this element is necessary?you've added some divs that are not necessary, for this challenge all you need is a <main> to wrap everything and manage the paddings and one img, h1 and p inside of it. See the cleanest structure possible below:<body> <main> <img> <h1></h1> <p></p> </main> </body>Hope it helps you Dennis my friend, and keep it up!
Happy coding!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord