qr-code-component-main using HTML & CSS

Community feedback

• 

  Atif Iqbal•3,200

  @atif-devPosted almost 2 years ago

  Hi Jihane, congrats🎉 on completing the challenge. Better take care about following points.

  • Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings. Use alt (alternate text) attribute as it is mentioned in your Accessibility Report. alt attribute is used for Screen readers technology. Why alt attribute matters? Read here.
  • There is unnecessary scroll in your solution, for fixing that proper centering modify your code as:

  body {
    background-color: var(--light-gray);
    display: grid;
    min-height: 100vh;
    place-content: center;
  }
  

  plus remove all the code from .main selector and remove height: 50%; from .card selector.

  • When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.

  (Have any questions🧪?reply to this comment😇)

  Hope you will find this Feedback Helpful.🙂

  Marked as helpful

  0

  ---

  

  Jihane•140

  @JijinetPosted almost 2 years ago

  @atif-dev thanks a lot, that was very helpful

  1