Qr-code-component-main using Flexbox

Community feedback

• 

  Ecem Gokdogan•9,380

  @ecemgoPosted over 1 year ago

  Some recommendations regarding your code that could be of interest to you. 🤗

  HTML

  In order to fix the accessibility issues:

  • You need to replace <div class="container"> with the <main> tag and <div class="attribution"> with the <footer> tag. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly.

  CSS

  • You can update the width of the card

  .container {
      max-width: 280px;      // max-width makes the card responsive
  }
  

  Hope I am helpful. :)

  Marked as helpful

  0

  ---

  

  Patrick Hugo•90

  @patrickhsaPosted over 1 year ago

  @ecemgo Thanks for your recomendations.

  1