Travolgi 🍕• 31,420
@denielden
Posted
Hello Thales, You have done a good work! 😁
Some little tips to improve your code:
- the image qr is broken... I think you forgot to upload the qr image in the repository
- add
main
tag and wrap the card for improve the Accessibility - also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - remove all
margin
from.container
class - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh and margin: 0
to body because Flexbox aligns child items to the size of the parent container - instead of using
px
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help 😉 and Happy coding!
Marked as helpful
0
Thales Rosário• 30
@thalesbsb
Posted
@denielden muito obrigado pelas dicas
1
Travolgi 🍕• 31,420
@denielden
Posted
@thalesbsb you are welcome and keep it up :)
Marked as helpful
0