Qr-code-component-main

Community feedback

• 

  Adriano•38,080

  @AdrianoEscarabotePosted about 2 years ago

  Hi sohail ebada, how are you?

  I really liked the result of your project, but I have some tips that I think you will enjoy:

  every html document must contain a main tag, so people who use screen readers know what the main content is!

  so to solve this problem, wrap all the content with the main tag, like this:

  <main>
    // content
  </main>
  

  The rest is great!

  I hope it helps... 👍

  0
• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 2 years ago

  Hi @sohailebada 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉

  I have some suggestions you might consider to improve your code:

  • Use the <main> tag to wrap all the main content in your solution instead of using <div class="container">.

  • Use <footer> instead of <div class="attribution">. The <footer> element contains authorship information.

  • To make alternative texts more worthwhile, add descriptive text to the alt attribute of the QR image to explain what the QR image does. Upon scanning the QR code, you will be redirected to the frontendmentor.io website, so an example of alternative text would be "QR code to frontendmentor.io". You can read more about alternative text here.

  • Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.

  • The container isn't centered correctly. You can use flexbox to center elements. You can read more about centering in CSS here.

  Above all, the project is done well👏. I hope those tips will help you! 👍

  Good job, and happy coding! 😁

  0