qr-code-component-main

Community feedback

• 

  Dion•150

  @dionlowPosted over 1 year ago

  Hey your project looks solid!

  Your github project structure nests the project into two folders like QR-code-component/qr-code-component-main/index.html to get your project. You can remove the nested folder qr-code-component-main so that when you go to the repo you can see the index.html file directly which will allow you to see the README.md directly from github. I actually made the same mistake since I made my own folder and the project unzipped it's own folder.

  <p> color You have the color set to the same as the background. You can use the darker color hsl(220, 15%, 55%) in the style guide to make it more visible and match more closely to the design

  Marked as helpful

  1
• 

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  Replace<div class="container">with the main tag, <h2> with <h1> and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

  To center .container on the page using flexbox, replace the height in the body with min-height: 100vh.

  For a responsive content which wont require a media query for this challenge, give .container a fixed max-width value . max-width: 320px .

  Give h1 and p the same font-size of 15px and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  Yassine Afaila•540

  @YassineafailaPosted over 1 year ago

  @Hassiai hi, Sorry but whos better to center div is giving the body hieght:100%; or height:100vh; and why you suggest the min-height??

  0

  

  Hassia Issah•50,650

  @HassiaiPosted over 1 year ago

  @Yassineafaila using min-height:100vh height will center the content on the page even if the height of the content is above 100vh.

  0

  

  Yassine Afaila•540

  @YassineafailaPosted over 1 year ago

  @Hassiai ohhhhhhh ok ok thanks

  0