Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

qr-code-component-main

@pasan2002

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedback welcome

Community feedback

Dion 150

@dionlow

Posted

Hey your project looks solid!

Your github project structure nests the project into two folders like QR-code-component/qr-code-component-main/index.html to get your project. You can remove the nested folder qr-code-component-main so that when you go to the repo you can see the index.html file directly which will allow you to see the README.md directly from github. I actually made the same mistake since I made my own folder and the project unzipped it's own folder.

<p> color You have the color set to the same as the background. You can use the darker color hsl(220, 15%, 55%) in the style guide to make it more visible and match more closely to the design

Marked as helpful

1
Hassia Issah 50,670

@Hassiai

Posted

Replace<div class="container">with the main tag, <h2> with <h1> and <div class="attribution"> with the footer tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

To center .container on the page using flexbox, replace the height in the body with min-height: 100vh.

For a responsive content which wont require a media query for this challenge, give .container a fixed max-width value . max-width: 320px .

Give h1 and p the same font-size of 15px and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

Hope am helpful.

Well done for completing this challenge. HAPPY CODING

Marked as helpful

0

@Yassineafaila

Posted

@Hassiai hi, Sorry but whos better to center div is giving the body hieght:100%; or height:100vh; and why you suggest the min-height??

0
Hassia Issah 50,670

@Hassiai

Posted

@Yassineafaila using min-height:100vh height will center the content on the page even if the height of the content is above 100vh.

0

@Yassineafaila

Posted

@Hassiai ohhhhhhh ok ok thanks

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord