@MelvinAguilar
Posted
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- The link of the GitHub repository is incorrect.
- Since this component involves scanning the QR code, the image is not a decoration, so it must have an
alt
attribute. Thealt
attribute should explain its purpose. e.g.QR code to frontendmentor.io
- You should use the
box-sizing: border-box
property to make thewidth
andheight
properties include the padding and border of the element. This will make it easier to calculate the size of an element. You can read more about this here ๐.
- Use
text-align: center
to the<div class="container">
to center the text in the card.
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
@sil3ntr
Posted
@MelvinAguilar thanks so much for taking the time to provide this actionable feedback, I really appreciate it. I have made the suggested changes and pushed to the github repo. I found the article you linked particularly helpful :)