qr-code-component-main

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • The link of the GitHub repository is incorrect.

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io

  • You should use the box-sizing: border-box property to make the width and height properties include the padding and border of the element. This will make it easier to calculate the size of an element. You can read more about this here 📘.

  • Use text-align: center to the <div class="container"> to center the text in the card.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  4

  ---

  

  sil3ntr•40

  @sil3ntrPosted almost 2 years ago

  @MelvinAguilar thanks so much for taking the time to provide this actionable feedback, I really appreciate it. I have made the suggested changes and pushed to the github repo. I found the article you linked particularly helpful :)

  0
• 

  namborghinii•220

  @namborghiniiPosted almost 2 years ago

  Good job on completing this challenge so far! :) Little reminder to center the bottom text and decrease the scale of the component in general so it fits on the screen without scrolling. Also add media queries for responsive Design and a box-shadow and you should be fine.

  Marked as helpful

  2

  ---

  

  sil3ntr•40

  @sil3ntrPosted almost 2 years ago

  @namborghinii thanks for your feedback, there was a box shadow already on their but I used a grey so its probably not quite as noticeable perhaps.

  I didn't add a media query in this case, having quickly tested in in dev tools I could see that it looked reasonable based on a couple of quick tests. I do understand this obviously was not an exhaustive test. Was there anything in particular you were suggesting, ie where it was not scaling correctly on mobile ?

  0

  

  namborghinii•220

  @namborghiniiPosted almost 2 years ago

  @sil3ntr I just tested it on mobile device and it looks fine! :))

  0

  

  sil3ntr•40

  @sil3ntrPosted almost 2 years ago

  @namborghinii , thanks for that, appreciated.

  0