qr-code-component-main

Community feedback

• 

  Agnik Bakshi•480

  @Agnik7Posted over 1 year ago

  Hi, Congratulations on completing the challenge. I have some tips that might be of help to you.

  • You are using the relative path in the src of the img tag. You have mentioned the path as /qr-code-component-main/image-qr-code.png. However, for any element present inside a secondary folder within the root folder, the path starts with ./. So, your correct path should be ./qr-code-component-main/image-qr-code.png . Always give an alt text, which specifies what to show if for any reason the image can't be displayed. Replace your img tag with the following. <img src="./qr-code-component-main/image-qr-code.png" alt="QR code image" />

  • Replace the h3 tag by the h1 tag. Always start from h1 and keep on decreasing one level. This will help prevent accessibility issues.

  • Wrap the whole content in the body of the html inside main tag. To learn more about accessibility and semantic html, click here.

  • In the index.html file, you are not using the style tag, so it's better to remove it. This helps you keep only the necessary lines of code.

  • While centering in the body, instead of height, define the min-height for better responsiveness. You don't need to add width:100% since, 100% of the width is taken by default if nothing is mentioned.

  • Define the max-width of the container, instead of the width to make it more responsive.

  Hope this feedback helps you to improve in the future. Have a nice day!!

  0

  ---

  

  tariqyunusa•70

  @tariqyunusaPosted over 1 year ago

  @Agnik7 Thank You so much this was very helpful

  0
• 

  RabbitMaid•1,020

  @AgbortokoPosted over 1 year ago

  You seem to have an issue with the display of your image. Currently this is what you did

  <img src="/qr-code-component-main/image-qr-code.png" alt="">
  

  You can replace the code above with this

  <img src="qr-code-component-main/image-qr-code.png" alt="Short Image Description"> The reason why the image does not due to the incorrect path. Though the path you used might be seen by some code editors, it will not be visible on the browser. Simply remove the slash at the beginning an the image will load.

  -Also all Images in your design should always have the alt attribute. This helps search engines easily understand what the image is all about.

  • HTML5 elements such as <main>, <nav>, <header>, <footer>, <section>, <aside> act as landmarks, or special regions on the page to which screen readers and other assistive technologies can jump. By using landmark elements, you can dramatically improve the navigation experience on your site for users of assistive technology (Users with disabilities) .

  You can use the <div> for sub items within landmarks like <section>. In other words for containers or sections in your html you can use the <section> tag.

  0

  ---

  

  tariqyunusa•70

  @tariqyunusaPosted over 1 year ago

  @Agbortoko thank you so much. this was very helpful.

  0