qr-code-component-main

Community feedback

• 

  Andrés Gutiérrez Ramírez•2,470

  @AGutierrezRPosted 11 months ago

  Hello there 👋. Good job on completing the challenge!

  I have some suggestions about your code that might interest you.

  General Structure and HTML:

  • Wrap the primary content within the <main> tag instead of using it as a standalone component like a <div>.
  • All the content should be contained within landmarks. Every page minimally needs a <main> element.
  • Consider using <h2> instead of <p> for elements that are titles, like the title of the card.
  • Consider merge the "Scan the QR code to visit Frontend", "Mentor and take your coding skills to" and "the next level" into a paragraph and play with the width using ch unit in order to match the design.

  CSS and Styling:

  • To center the card use the following styles

    body {
      display: flex;
      justify-content: center;
      align-items: center;
      min-height: 100vh;
    }
    

    and remove the position: absolute, margin-left: 40% and margin-top: 10% from the .container-fluid

  • Implement CSS custom properties to define and utilize project colors more easily.

  I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!

  Happy coding!

  Marked as helpful

  0

  ---

  

  Jomar Perez•30

  @JPerez03Posted 11 months ago

  Thank you for the tip @AGutierrezR

  0