@IvelinDankov
Posted
Great Job! I see you can proof some details. make h1, h2, h3 semantic. You can use p element as well for small text. your card width look like not the same try to improve next time.
But for first challenge is good!
This is my first project on Front-End mentor and I already build some frontend projects so there is no defficullty.
@IvelinDankov
Posted
Great Job! I see you can proof some details. make h1, h2, h3 semantic. You can use p element as well for small text. your card width look like not the same try to improve next time.
But for first challenge is good!
@danielmrz-dev
Posted
Hello @V-mandloi!
Your solution looks great!
I have a couple of suggestions for improvement:
<h1>
for the main title instead of <h3>
. Unlike what most people think, it's not just about the size and weight of the text.š The <h1>
to <h6>
tags are used to define HTML headings.
š <h1>
defines the most important heading.
š <h6>
defines the least important heading.
š Only use one <h1>
per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>
, then use <h2>
, and so on.
<main>
to wrap the main content instead of <div>
.All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord