qr-code-component-main

Community feedback

• 

  Velin Dankov•160

  @IvelinDankovPosted 10 months ago

  Great Job! I see you can proof some details. make h1, h2, h3 semantic. You can use p element as well for small text. your card width look like not the same try to improve next time.

  But for first challenge is good!

  0
• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 10 months ago

  Hello @V-mandloi!

  Your solution looks great!

  I have a couple of suggestions for improvement:

  • First: In order to make your HTML code more semantic, use <h1> for the main title instead of <h3>. Unlike what most people think, it's not just about the size and weight of the text.

  📌 The <h1> to <h6> tags are used to define HTML headings.

  📌 <h1> defines the most important heading.

  📌 <h6> defines the least important heading.

  📌 Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  • Second: Still about semantic HTML, use <main> to wrap the main content instead of <div>.

  All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  0